fix: onMount prop conflict with ReactMonacoEditor component #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoventura
requested review from
going-confetti and
Llandy3d
and removed request for
a team
| @@ -71,7 +82,7 @@ export function ReactMonacoEditor({ | |||
| ...props.options, | |||
| wordWrap: toolbarState.wordWrap, | |||
| }} | |||
| onMount={(editor) => setEditor(editor)} | |||
There was a problem hiding this comment.
This was overriding the onMount prop declared in the CodeEditor component:
k6-studio/src/components/Monaco/CodeEditor.tsx
Lines 20 to 40 in 0678c9b
This prevented the content of script preview from being set.
Comment on lines
+65
to
+67
| if (props.onMount) { | ||
| props.onMount(editor, monaco) | ||
| } |
There was a problem hiding this comment.
Now we're setting the instance of editor here but still respecting what the parent component is doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug that was introduced in #355 and caused the instance of the Monaco Editor in the "Script Preview" tab to show with no content after the first render.
How to Test
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)